This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Numpy] Numpy behavior random.uniform() #15858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haojin2
requested review from
haojin2 and
reminisce
and removed request for
szha
August 12, 2019 18:07
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 12, 2019
haojin2
reviewed
Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current
mx.np.random.uniform
does not support parameters (low and high) asNdarray
, as the current version is implemented by wrappingmxnet.ndarray.random.uniform
, which behaves in a different way when the output shape is given by the user compared with native Numpy.For example:
mxnet.ndarray.random.uniform(low, high, shape)
would have output tensor of shape 1x4x2x4x4, however, result fromnumpy.random.uniform(low, high, shape)
would have shape 2x4x4.Another major difference is that, numpy allows parameters to have different shapes as long as they are broadcastable.
For example:
This setting would cause
Operator _sample_uniform inferring shapes failed.
withmxnet.ndarray.random.uniform
.This pull request implements a uniform distribution generator with numpy behavior and GPU support.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments
size
is not defined, a scalar tensor would be returned. This is different from native Numpy, which would return python scalar if both parameters are python scalar.For example: